Skip to content

fix workflow triggering condition #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

fix workflow triggering condition #136

merged 3 commits into from
Apr 11, 2025

Conversation

@Saga4
Copy link
Contributor

@Saga4 Saga4 commented Apr 10, 2025 •
edited by github-actions bot
Loading

PR Type

  • Enhancement

Description

  • Added specific file triggers for pull_request_target.

  • Ignored workflows on unrelated pull_request events.

  • Standardized triggers across multiple workflow YAMLs.

Changes walkthrough 📝

Relevant files
Configuration changes
8 files
codeflash-optimize.yaml
Updated workflow trigger conditions config                             
+8/-1     
end-to-end-test-bubblesort-pytest-no-git.yaml
Updated test workflow trigger filtering                                   
+9/-0     
end-to-end-test-bubblesort-unittest.yaml
Updated unit test workflow trigger filtering                         
+9/-0     
end-to-end-test-coverage.yaml
Updated coverage workflow trigger configuration                   
+9/-0     
end-to-end-test-futurehouse.yaml
Updated futurehouse workflow trigger settings                       
+9/-0     
end-to-end-test-init-optim.yaml
Updated init optimization workflow trigger config               
+9/-0     
end-to-end-test-tracer-replay.yaml
Updated tracer replay workflow trigger conditions               
+9/-0     
end-to-end-topological-sort-test.yaml
Updated topological sort workflow trigger settings             
+9/-0     
Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    •

    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 16:26 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 16:26 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 16:26 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 16:26 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 16:26 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 16:26 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 16:26 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 16:26 — with GitHub Actions Error
    @github-actions github-actions bot added workflow-modified This PR modifies GitHub Actions workflows Review effort 2/5 labels Apr 10, 2025
    @github-actions
    Copy link

    github-actions bot commented Apr 10, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Maintainability

    Similar trigger configurations are repeated across multiple workflow files. Consider verifying that the same pattern applies uniformly and evaluating if the configuration can be consolidated or templated to reduce duplication.

     
    # For specific file changes
pull_request_target:
  paths:
    - '.github/workflows/**'

# For all other changes
pull_request:
  paths-ignore:
    - '.github/workflows/**'

    @github-actions
    Copy link

    github-actions bot commented Apr 10, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    misrasaurabh1
    misrasaurabh1 reviewed Apr 10, 2025
    View reviewed changes
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 21:47 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 21:47 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 21:47 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 21:47 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 21:47 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 21:47 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 21:47 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 10, 2025 21:47 — with GitHub Actions Error
    @Saga4 Saga4 requested a review from misrasaurabh1 April 10, 2025 21:52
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 11, 2025 05:04 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 11, 2025 05:04 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 11, 2025 05:04 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 11, 2025 05:04 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 11, 2025 05:04 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 11, 2025 05:04 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 11, 2025 05:04 — with GitHub Actions Failure
    @Saga4 Saga4 had a problem deploying to external-trusted-contributors April 11, 2025 05:04 — with GitHub Actions Error
    @Saga4 Saga4 merged commit 7d7340c into main Apr 11, 2025
    8 of 16 checks passed
    KRRT7 pushed a commit that referenced this pull request Apr 14, 2025
    @Saga4 @KRRT7
    fix workflow triggering condition (#136)
    548c40a 
    * fix workflow triggering condition

* fix run
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @misrasaurabh1 misrasaurabh1 misrasaurabh1 approved these changes

    Assignees

    No one assigned

    Labels

    Review effort 2/5 workflow-modified This PR modifies GitHub Actions workflows

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @Saga4 @misrasaurabh1